Upgrades leave .forgejo/pull_request_template.md stale #221

New issue

Closed

opened 2026-11-12 09:14:18 +01:00 by motoko · 0 comments

motoko commented

2026-11-12 09:14:18 +01:00

Collaborator

Seen at b04e7781d7.

Location

UPGRADING.md step 3, lines 16–18: the root .forgejo/ stays in the
source.
UPGRADING.md § Migrations, Pull request template (around line
265), which copies .agents/templates/pull-request.md to
.forgejo/pull_request_template.md only "while the main branch,
before the merge, lacks .agents/templates/pull-request.md".
docs/INSTALL.md adoption step 4, which makes the same copy at
adoption.

Evidence

After adoption, or after the migration has run once, a Forgejo
repository holds two copies of the pull request form:
.agents/templates/pull-request.md, which step 3 merges on every
upgrade, and .forgejo/pull_request_template.md, which nothing touches
again: step 3 leaves the root .forgejo/ to the source, and the
migration no longer applies once the template exists. Nothing in the
adopting repository records that the .forgejo/ file is a copy.

Scenario

The source revises the form, as b04e778 (feat(templates): aim PR bodies
at outside readers) did. On the next upgrade, agents' pull request
bodies follow the new .agents/ template, while a person who opens a
pull request in Forgejo's web UI still gets the old form, and the two
drift further with each upgrade.

Smallest fix

In UPGRADING.md step 3, also update .forgejo/pull_request_template.md
from the chosen commit's .agents/templates/pull-request.md when it
still matches the adopted commit's, and ask the user when it differs.

Seen at b04e7781d795547882b7bd47b878057cc9cdec32. ## Location - `UPGRADING.md` step 3, lines 16–18: the root `.forgejo/` stays in the source. - `UPGRADING.md` § Migrations, **Pull request template** (around line 265), which copies `.agents/templates/pull-request.md` to `.forgejo/pull_request_template.md` only "while the main branch, before the merge, lacks `.agents/templates/pull-request.md`". - `docs/INSTALL.md` adoption step 4, which makes the same copy at adoption. ## Evidence After adoption, or after the migration has run once, a Forgejo repository holds two copies of the pull request form: `.agents/templates/pull-request.md`, which step 3 merges on every upgrade, and `.forgejo/pull_request_template.md`, which nothing touches again: step 3 leaves the root `.forgejo/` to the source, and the migration no longer applies once the template exists. Nothing in the adopting repository records that the `.forgejo/` file is a copy. ## Scenario The source revises the form, as b04e778 (feat(templates): aim PR bodies at outside readers) did. On the next upgrade, agents' pull request bodies follow the new `.agents/` template, while a person who opens a pull request in Forgejo's web UI still gets the old form, and the two drift further with each upgrade. ## Smallest fix In `UPGRADING.md` step 3, also update `.forgejo/pull_request_template.md` from the chosen commit's `.agents/templates/pull-request.md` when it still matches the adopted commit's, and ask the user when it differs.

motoko referenced this issue from a commit

2026-11-12 15:38:30 +01:00

fix(upgrade): renew a copied Forgejo PR form

motoko referenced this issue from a pull request that will close it,

2026-11-12 15:38:41 +01:00

fix(upgrade): renew a copied Forgejo PR form #223