review template's goal statement asks pins of others' pull requests #153
Loading…
Add table
Add a link
Reference in a new issue
No description provided.
Delete branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Location
.agents/templates/review.md, the Goal statement comment (lines16–20): the goal statement takes "the form the work template gives a
Brief".
.agents/templates/work.md, the Constraints comment (lines 56–65): "abehavior no test guards first getting a pin, as AGENTS.md § Testing
and verification names it".
Seen at
150d921.Evidence
The review template sends
review-prto the work template's Brief forthe goal statement's form, and so to its Constraints comment. That
comment asks that a kept behavior no test guards first get a pin, a
committed test.
review-prreviews a pull request someone else openedand commits nothing to it, so the pin cannot exist. The old form,
review-pr/review.md, borrowed the same comment, so this predates thereview template.
Scenario
An agent writes the goal statement for a pull request that keeps a
behavior no test guards. Following the Constraints comment, it either
stops to ask whether it should write a pin, or writes a constraint that
asks for one, and the reviewers then judge the pull request against a
pin nobody can add.
Smallest fix
In the review template's Goal statement comment, add: "Its Constraints
name the tests that guard each kept behavior, or that none does,
without pins."