claudiomaradonna/agent-foundry
claudiomaradonna/agent-foundry
Template
1
0
Fork 0
Code Issues Pull requests Activity Actions

fix(templates): ask no pin in a review's goal statement #165

Merged
claudiomaradonna merged 1 commit from fix/review-goal-pins into main 2026-10-29 09:09:26 +01:00
Conversation 0 Commits 1 Files changed 1 +3 -1
motoko commented 2026-10-29 00:12:41 +01:00
Collaborator
Copy link

Why

An agent running review-pr writes a goal statement for the pull
request in the form the work template gives a Brief. That form's
Constraints ask a pin first for any kept behavior that no test guards.
A review of someone else's pull request commits nothing to it, so the
pin can never exist. Today the agent either stops to ask whether to
write one, or writes a constraint that asks for one, and the reviewers
then judge the pull request against a test nobody can add. Fixes #153.

I also considered splitting the pin clause out of the work template so
the review template could leave it out by name. I set that aside
because it touches two templates to get the same effect.

What changed

The goal statement comment in .agents/templates/review.md now says
that its Constraints name, for each behavior and interface the pull
request keeps, the tests that guard it, or that none does, in place of
a pin. It gives the reason: a review commits nothing to the pull
request. The work template and the pin rule in AGENTS.md stay as
they are.

How to verify

On a fresh checkout of the branch, read the comment under
## Goal statement in .agents/templates/review.md. Then picture an
agent writing the goal statement for a pull request that keeps a
behavior no test guards. The comment should tell it to record that no
test guards the behavior, and to add no pin. On main, the same agent
reaches the work template's "first getting a pin" clause and has
nothing to settle it. The text check
sed -n '/^## Goal statement/,/^### Problem/p' .agents/templates/review.md | grep -c -i pin
prints 1 on the branch and 0 on main.

The README's Maintenance checks pass on 579bfbd, including 299
agent-configuration tests. The change, security and document reviewers
report no findings; the document reviewer's two low findings on the
draft are already applied. The behavioral evals did not run, because
each run is billed. Under the Maintenance section, that run is for the
maintainer before merging a template change.

## Why An agent running `review-pr` writes a goal statement for the pull request in the form the work template gives a Brief. That form's Constraints ask a pin first for any kept behavior that no test guards. A review of someone else's pull request commits nothing to it, so the pin can never exist. Today the agent either stops to ask whether to write one, or writes a constraint that asks for one, and the reviewers then judge the pull request against a test nobody can add. Fixes #153. I also considered splitting the pin clause out of the work template so the review template could leave it out by name. I set that aside because it touches two templates to get the same effect. ## What changed The goal statement comment in `.agents/templates/review.md` now says that its Constraints name, for each behavior and interface the pull request keeps, the tests that guard it, or that none does, in place of a pin. It gives the reason: a review commits nothing to the pull request. The work template and the pin rule in `AGENTS.md` stay as they are. ## How to verify On a fresh checkout of the branch, read the comment under `## Goal statement` in `.agents/templates/review.md`. Then picture an agent writing the goal statement for a pull request that keeps a behavior no test guards. The comment should tell it to record that no test guards the behavior, and to add no pin. On `main`, the same agent reaches the work template's "first getting a pin" clause and has nothing to settle it. The text check `sed -n '/^## Goal statement/,/^### Problem/p' .agents/templates/review.md | grep -c -i pin` prints `1` on the branch and `0` on `main`. The README's Maintenance checks pass on 579bfbd, including 299 agent-configuration tests. The change, security and document reviewers report no findings; the document reviewer's two low findings on the draft are already applied. The behavioral evals did not run, because each run is billed. Under the Maintenance section, that run is for the maintainer before merging a template change. 
The review template's goal statement takes the work template's Brief
form, whose Constraints ask a pin for a kept behavior no test guards.
A review of someone else's pull request commits nothing to it, so the
goal statement now records the tests that guard each kept behavior and
interface, or that none does, in place of a pin.

Fixes #153
motoko force-pushed fix/review-goal-pins from 579bfbdf21 to 856fb710a2 2026-10-29 09:03:45 +01:00 Compare
claudiomaradonna deleted branch fix/review-goal-pins 2026-10-29 09:09:29 +01:00
Sign in to join this conversation.
Reviewers
No reviewers
Labels
Clear labels
No items
No labels
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
claudiomaradonna/agent-foundry!165
No description provided.