claudiomaradonna/agent-foundry
claudiomaradonna/agent-foundry
Template
1
0
Fork 0
Code Issues Pull requests Activity Actions

docs(forge): trim fj.md's pull request template section #173

Merged
claudiomaradonna merged 1 commit from docs/fj-template-trim into main 2026-10-29 20:26:17 +01:00
Conversation 0 Commits 1 Files changed 3 +9 -12
motoko commented 2026-10-29 19:55:51 +01:00
Collaborator
Copy link

Why

Every agent that loads forge's fj.md for a forge action read how fj
looks up a pull request template, its 24 requests, and the path list,
though it always publishes from --body-file and only needs to know
that its body stands alone. The path list served only the adoption step
and the upgrade migration, which sent their readers to fj.md for it.
Fixes #170.

Cutting the section to one sentence, as the issue proposed, was set
aside: README.md step 4 and UPGRADING.md cite the list, and would
have pointed at nothing. Keeping the list in fj.md was set aside too,
as every forge action would still load it.

What changed

fj.md now says only that a body given with --body-file replaces any
pull request template the repository holds. The template paths, as a
set of four directories, two names, and three extensions, now sit in
README adoption step 4, which decides whether to copy the template to
.forgejo/; the UPGRADING.md migration cites that step instead of
fj.md.

How to verify

On the branch, read the "Pull request template" section of
.agents/skills/forge/fj.md: one sentence. Then follow README adoption
step 4 for a repository on Forgejo that holds
.github/PULL_REQUEST_TEMPLATE.yml: the step alone tells you not to
copy the template; on main it sends you to fj.md for the paths.

The source's Maintenance checks pass on the tip: bash tests/verify-agent-config.sh (319 passed), bash tests/check-work-folder.sh, .agents/hooks/shellcheck.sh repo,
prettier --check '**/*.md', scripts/verify-agent-config.sh, and
git diff --check main. The behavioral evals were not run, as each run
is billed.

## Why Every agent that loads `forge`'s `fj.md` for a forge action read how fj looks up a pull request template, its 24 requests, and the path list, though it always publishes from `--body-file` and only needs to know that its body stands alone. The path list served only the adoption step and the upgrade migration, which sent their readers to `fj.md` for it. Fixes #170. Cutting the section to one sentence, as the issue proposed, was set aside: `README.md` step 4 and `UPGRADING.md` cite the list, and would have pointed at nothing. Keeping the list in `fj.md` was set aside too, as every forge action would still load it. ## What changed `fj.md` now says only that a body given with `--body-file` replaces any pull request template the repository holds. The template paths, as a set of four directories, two names, and three extensions, now sit in README adoption step 4, which decides whether to copy the template to `.forgejo/`; the `UPGRADING.md` migration cites that step instead of `fj.md`. ## How to verify On the branch, read the "Pull request template" section of `.agents/skills/forge/fj.md`: one sentence. Then follow README adoption step 4 for a repository on Forgejo that holds `.github/PULL_REQUEST_TEMPLATE.yml`: the step alone tells you not to copy the template; on main it sends you to `fj.md` for the paths. The source's Maintenance checks pass on the tip: `bash tests/verify-agent-config.sh` (319 passed), `bash tests/check-work-folder.sh`, `.agents/hooks/shellcheck.sh repo`, `prettier --check '**/*.md'`, `scripts/verify-agent-config.sh`, and `git diff --check main`. The behavioral evals were not run, as each run is billed. 
An agent creating a pull request always passes --body-file, so it only
needs to know that the body replaces any template; the lookup order and
request count it never acted on go. The template paths, which only the
adoption step and the upgrade migration use, move into README step 4,
which the migration now cites.

Fixes #170
motoko force-pushed docs/fj-template-trim from 3e07de40e8 to c660f718cc 2026-10-29 20:12:56 +01:00 Compare
claudiomaradonna deleted branch docs/fj-template-trim 2026-10-29 20:26:26 +01:00
Sign in to join this conversation.
Reviewers
No reviewers
Labels
Clear labels
No items
No labels
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
claudiomaradonna/agent-foundry!173
No description provided.