claudiomaradonna/azkaban
1
1
Fork 0
Code Issues Pull requests Activity

feat: add --skip-custom-images for one launch #39

Merged
claudiomaradonna merged 1 commit from feat/skip-custom-images-option into master 2026-10-07 22:09:57 +02:00
Conversation 0 Commits 1 Files changed 4 +36 -10
motoko commented 2026-10-07 22:09:07 +02:00
Collaborator
Copy link

Why

Running a clean client in a folder that carries Dockerfile.<client> or
Dockerfile.azkaban meant naming the stock image with --image or
editing the identity's env.

What changed

--skip-custom-images sets the SKIP_CUSTOM_IMAGES control to 1 for one
launch, outranking the identity's files like every other control option,
so neither workspace Dockerfile is built or offered for approval. The
build-failure message and the README's troubleshooting entry now point
to the switch, since it needs no image name.

Verification

make lint && .agents/hooks/shellcheck.sh repo && make test passes; the
extended tests fail against master's launcher. make smoke-images and a
real launch with the switch were not run.

## Why Running a clean client in a folder that carries `Dockerfile.<client>` or `Dockerfile.azkaban` meant naming the stock image with `--image` or editing the identity's `env`. ## What changed `--skip-custom-images` sets the `SKIP_CUSTOM_IMAGES` control to 1 for one launch, outranking the identity's files like every other control option, so neither workspace Dockerfile is built or offered for approval. The build-failure message and the README's troubleshooting entry now point to the switch, since it needs no image name. ## Verification `make lint && .agents/hooks/shellcheck.sh repo && make test` passes; the extended tests fail against master's launcher. `make smoke-images` and a real launch with the switch were not run. 
Skipping a workspace Dockerfile for a single launch meant naming the
stock image with --image or editing the identity's env. The new switch
sets the SKIP_CUSTOM_IMAGES control to 1 from the command line, which
outranks the identity's files like every other control option, so a
clean client runs in a folder that carries Dockerfile.<client> or
Dockerfile.azkaban without building it.

The build-failure message and the README's troubleshooting entry now
point to the switch, since it needs no image name.
claudiomaradonna deleted branch feat/skip-custom-images-option 2026-10-07 22:10:00 +02:00
Sign in to join this conversation.
Reviewers
No reviewers
Labels
Clear labels
No items
No labels
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
claudiomaradonna/azkaban!39
No description provided.