claudiomaradonna/castrum
1
0
Fork 0
Code Issues Pull requests Activity

docs(contributing): correct the no-scenario note #38

Merged
claudiomaradonna merged 1 commit from docs/contributing-untested-roles into main 2026-10-09 01:01:26 +02:00
Conversation 0 Commits 1 Files changed 1 +3 -2
motoko commented 2026-10-09 00:59:37 +02:00
Collaborator
Copy link

Why

The Molecule section of CONTRIBUTING said "A role with no tasks needs no
scenario, and os-updates and sysadmin-tools have none", which reads as if
those two roles have no tasks. They do: os-updates upgrades every package
and can reboot, and sysadmin-tools sets the hostname. The roles with no
tasks are the ones that only ship a port file.

What changed

The sentence now says a role with no tasks, such as one that only ships a
port file, needs no scenario, and that os-updates and sysadmin-tools have
tasks and no scenario, so their tasks first run on the first host of a
live batch. Whether to give them scenarios is left open.

Verification

make check green. make test not run (no podman); the change is
docs-only.

## Why The Molecule section of CONTRIBUTING said "A role with no tasks needs no scenario, and os-updates and sysadmin-tools have none", which reads as if those two roles have no tasks. They do: os-updates upgrades every package and can reboot, and sysadmin-tools sets the hostname. The roles with no tasks are the ones that only ship a port file. ## What changed The sentence now says a role with no tasks, such as one that only ships a port file, needs no scenario, and that os-updates and sysadmin-tools have tasks and no scenario, so their tasks first run on the first host of a live batch. Whether to give them scenarios is left open. ## Verification `make check` green. `make test` not run (no podman); the change is docs-only. 
The Molecule section said "A role with no tasks needs no scenario, and
os-updates and sysadmin-tools have none", which reads as if those two
roles have no tasks. They do: os-updates upgrades every package and can
reboot, and sysadmin-tools sets the hostname. The roles with no tasks
are the ones that only ship a port file.

Say so, and state that os-updates and sysadmin-tools have tasks but no
scenario, so their tasks first run on the first host of a live batch.
claudiomaradonna deleted branch docs/contributing-untested-roles 2026-10-09 01:01:33 +02:00
Sign in to join this conversation.
Reviewers
No reviewers
Labels
Clear labels
No items
No labels
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
claudiomaradonna/castrum!38
No description provided.