unitoo/website
1
0
Fork 1
Code Issues 1 Pull requests Packages 1 Activity

fix(ui/sass/build): make FAQ visible and silence Sass deprecation warnings #71

Merged
claudiomaradonna merged 3 commits from fix/faq-static-and-sass-deprecations into master 2026-06-01 15:07:54 +02:00
Conversation 0 Commits 3 Files changed 11 +60 -117
claudiomaradonna commented 2026-06-01 15:07:33 +02:00
Collaborator
Copy link

The Bootstrap 4 accordion markup on the FAQ page used data-toggle/data-target/collapse
attributes that Bootstrap 5 never initialises, so all FAQ answers were invisible to anyone
without the accordion JS running. The fix replaces the accordion with plain h3/p pairs
so the content is always visible without any JavaScript. The same pass corrects a missing
comma in the about-us copy ("Small moves, Ellie.") in both EN and IT strings.

Alongside that, the Sass build was emitting a wall of deprecation warnings on every
jekyll build invocation. The color-channel functions (red, green, blue, darken,
lighten, mix), slash-division syntax, and the Bootstrap-vendored if()/global-builtin
usages have all been migrated to the sass:color and sass:math module APIs in the
project's own partials and in the three vendored Bootstrap 5 partials. Deprecations that
originate from deeper inside the vendored code and cannot be cleanly refactored without
more aggressively forking Bootstrap are suppressed via silence_deprecations in
_config.yml as a deliberate temporary measure.

The Bootstrap 4 accordion markup on the FAQ page used `data-toggle`/`data-target`/`collapse` attributes that Bootstrap 5 never initialises, so all FAQ answers were invisible to anyone without the accordion JS running. The fix replaces the accordion with plain `h3`/`p` pairs so the content is always visible without any JavaScript. The same pass corrects a missing comma in the about-us copy ("Small moves, Ellie.") in both EN and IT strings. Alongside that, the Sass build was emitting a wall of deprecation warnings on every `jekyll build` invocation. The color-channel functions (`red`, `green`, `blue`, `darken`, `lighten`, `mix`), slash-division syntax, and the Bootstrap-vendored `if()`/global-builtin usages have all been migrated to the `sass:color` and `sass:math` module APIs in the project's own partials and in the three vendored Bootstrap 5 partials. Deprecations that originate from deeper inside the vendored code and cannot be cleanly refactored without more aggressively forking Bootstrap are suppressed via `silence_deprecations` in `_config.yml` as a deliberate temporary measure.
The Bootstrap 4 accordion used data-toggle/data-target/collapse
attributes that have no effect under Bootstrap 5. All FAQ answers
were hidden by default (class="collapse") and only visible if JS
ran the accordion initialisation, which it no longer does.

Replace with plain h3 + p pairs inside a wrapping div so the
content is always visible and no JS is required. Visual separation
is preserved with the existing border-bottom/pb-3 classes.

Also fixes a missing comma in the about-us header copy in both
EN and IT strings ("Small moves Ellie." -> "Small moves, Ellie.").
Sass 1.x deprecated the standalone color channel functions (red,
green, blue), mix, darken, lighten, and slash-division syntax.
Replace with the sass:color and sass:math module APIs throughout
the project's own partials and the vendored Bootstrap 5 partials.

Changes:
- _base.scss: darken() -> color.adjust($lightness: -N%), slash ->
  calc(), add @use 'sass:color'
- _styles.scss: lighten/darken -> color.adjust(), add @use 'sass:color'
- bootstrap5/_functions.scss: red/green/blue -> color.channel(),
  mix -> color.mix(), opacity -> color.alpha(),
  array index now uses math.round(); add @use sass:color/math
- bootstrap5/_variables.scss: mix -> color.mix(); add @use sass:color
- bootstrap5/_variables-dark.scss: mix -> color.mix(); add @use sass:color
The sass:color and calc() migrations above eliminate most warnings,
but three categories remain from deeply embedded vendored code that
cannot be cleanly refactored without forking Bootstrap more
aggressively: @import (replaced by @use in a future pass), the
legacy if-function syntax, and global-builtin color functions used
inside Bootstrap's own generated mixins.

Add silence_deprecations to _config.yml's sass block as a deliberate
temporary measure to keep the build output clean while the vendored
partials are progressively updated.
claudiomaradonna deleted branch fix/faq-static-and-sass-deprecations 2026-06-01 15:07:59 +02:00
Sign in to join this conversation.
Reviewers
No reviewers
Labels
Clear labels
No items
No labels
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
unitoo/website!71
No description provided.